Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): revert almanac apis changes #1121

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

gautamgambhir97
Copy link
Collaborator

Proposed Changes

Revert almanac apis changes

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Content update.
  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

Further comments

[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]

@FelixNicolaeBucsa
Copy link
Collaborator

Why reverting? PR for suggested changes is here as well: #1117

@gautamgambhir97 gautamgambhir97 merged commit f65ed2a into main Jan 3, 2025
4 checks passed
@gautamgambhir97 gautamgambhir97 deleted the fix/revert-almanac-apis-changes branch January 3, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants